Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): make it real action #6745

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Apr 30, 2024

No description provided.

Copy link

graphite-app bot commented Apr 30, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

Copy link
Collaborator Author

pengx17 commented Apr 30, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @pengx17 and the rest of your teammates on Graphite Graphite

@pengx17 pengx17 marked this pull request as ready for review April 30, 2024 03:04
Copy link

nx-cloud bot commented Apr 30, 2024

@pengx17 pengx17 requested a review from fundon April 30, 2024 03:04
Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.86%. Comparing base (a1169a4) to head (9b28e73).

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #6745      +/-   ##
==========================================
- Coverage   64.86%   64.86%   -0.01%     
==========================================
  Files         581      581              
  Lines       27188    27188              
  Branches     2428     2428              
==========================================
- Hits        17636    17635       -1     
- Misses       9287     9288       +1     
  Partials      265      265              
Flag Coverage Δ
server-test 74.63% <ø> (ø)
unittest 40.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pengx17 pengx17 requested a review from EYHN April 30, 2024 03:29
Copy link

graphite-app bot commented Apr 30, 2024

Merge activity

@pengx17 pengx17 force-pushed the xp/04-30-fix_core_make_it_real_action branch from d788b5d to 9b28e73 Compare April 30, 2024 03:33
@graphite-app graphite-app bot merged commit 9b28e73 into canary Apr 30, 2024
32 checks passed
@graphite-app graphite-app bot deleted the xp/04-30-fix_core_make_it_real_action branch April 30, 2024 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants