Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): replace setting content scroll with radix ScrollArea #6787

Merged
merged 1 commit into from
May 7, 2024

Conversation

CatsJuice
Copy link
Member

@CatsJuice CatsJuice commented May 7, 2024

Use global scroll-area style

CleanShot 2024-05-07 at 10.58.01@2x.png

Copy link

graphite-app bot commented May 7, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @CatsJuice and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented May 7, 2024

@CatsJuice CatsJuice force-pushed the catsjuice/feat/settings-radix-scroll-area branch from 69579fd to ba64f55 Compare May 7, 2024 02:58
@CatsJuice CatsJuice requested review from EYHN, JimmFly and pengx17 May 7, 2024 02:59
@CatsJuice CatsJuice marked this pull request as ready for review May 7, 2024 02:59
Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.34%. Comparing base (cb3e7d0) to head (7234e23).

Additional details and impacted files
@@             Coverage Diff             @@
##           canary    #6787       +/-   ##
===========================================
+ Coverage   66.84%   77.34%   +10.49%     
===========================================
  Files         580      168      -412     
  Lines       27106    19389     -7717     
  Branches     2519     1237     -1282     
===========================================
- Hits        18120    14996     -3124     
+ Misses       8718     4352     -4366     
+ Partials      268       41      -227     
Flag Coverage Δ
server-test 77.34% <ø> (-0.01%) ⬇️
unittest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented May 7, 2024

Merge activity

@EYHN EYHN force-pushed the catsjuice/feat/settings-radix-scroll-area branch from ba64f55 to 7234e23 Compare May 7, 2024 03:19
@graphite-app graphite-app bot merged commit 7234e23 into canary May 7, 2024
32 checks passed
@graphite-app graphite-app bot deleted the catsjuice/feat/settings-radix-scroll-area branch May 7, 2024 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants