Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add multiDelete to trash page #6798

Merged
merged 1 commit into from
May 7, 2024

Conversation

JimmFly
Copy link
Member

@JimmFly JimmFly commented May 7, 2024

close #6739

2024-05-07.1.28.50.mov

Copy link

graphite-app bot commented May 7, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@JimmFly JimmFly marked this pull request as ready for review May 7, 2024 05:34
Copy link
Member Author

JimmFly commented May 7, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JimmFly and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented May 7, 2024

@JimmFly JimmFly requested a review from EYHN May 7, 2024 05:36
Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.84%. Comparing base (4751081) to head (eac55fe).

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #6798      +/-   ##
==========================================
+ Coverage   66.77%   66.84%   +0.06%     
==========================================
  Files         580      580              
  Lines       27108    27108              
  Branches     2520     2521       +1     
==========================================
+ Hits        18102    18120      +18     
+ Misses       8738     8720      -18     
  Partials      268      268              
Flag Coverage Δ
server-test 77.34% <ø> (+0.09%) ⬆️
unittest 40.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the test Related to test cases label May 7, 2024
Copy link

graphite-app bot commented May 7, 2024

Merge activity

@graphite-app graphite-app bot merged commit eac55fe into canary May 7, 2024
32 checks passed
@graphite-app graphite-app bot deleted the jimmfly/0507/multiDelete branch May 7, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core test Related to test cases
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

​Recycle bin improvements
2 participants