Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): allow promotion codes if no discount applied #6810

Merged
merged 1 commit into from
May 7, 2024

Conversation

forehalo
Copy link
Member

@forehalo forehalo commented May 7, 2024

No description provided.

Copy link

graphite-app bot commented May 7, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

forehalo commented May 7, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @forehalo and the rest of your teammates on Graphite Graphite

Copy link

codecov bot commented May 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 66.84%. Comparing base (b2b99ab) to head (7041991).

Files Patch % Lines
...ages/backend/server/src/plugins/payment/service.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #6810      +/-   ##
==========================================
- Coverage   66.93%   66.84%   -0.10%     
==========================================
  Files         580      580              
  Lines       27108    27108              
  Branches     2522     2522              
==========================================
- Hits        18146    18119      -27     
- Misses       8695     8721      +26     
- Partials      267      268       +1     
Flag Coverage Δ
server-test 77.34% <0.00%> (-0.11%) ⬇️
unittest 40.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented May 7, 2024

Merge activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants