Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): navigation shortcut keys can't be used when the sidebar is collapsed #6903

Merged
merged 1 commit into from
May 13, 2024

Conversation

JimmFly
Copy link
Member

@JimmFly JimmFly commented May 13, 2024

close #6877

Copy link

graphite-app bot commented May 13, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@JimmFly JimmFly marked this pull request as ready for review May 13, 2024 06:14
Copy link
Member Author

JimmFly commented May 13, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JimmFly and the rest of your teammates on Graphite Graphite

@JimmFly JimmFly requested a review from EYHN May 13, 2024 06:15
Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.70%. Comparing base (644bd8c) to head (df6d0a2).

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #6903      +/-   ##
==========================================
+ Coverage   66.68%   66.70%   +0.02%     
==========================================
  Files         583      582       -1     
  Lines       27179    27169      -10     
  Branches     2530     2530              
==========================================
  Hits        18124    18124              
+ Misses       8787     8777      -10     
  Partials      268      268              
Flag Coverage Δ
server-test 77.31% <ø> (ø)
unittest 40.23% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented May 13, 2024

Merge activity

@Brooooooklyn Brooooooklyn force-pushed the jimmfly/0513/fix-nav-shortcut branch from b3b8709 to df6d0a2 Compare May 13, 2024 07:15
@graphite-app graphite-app bot merged commit df6d0a2 into canary May 13, 2024
32 checks passed
@graphite-app graphite-app bot deleted the jimmfly/0513/fix-nav-shortcut branch May 13, 2024 07:25
@aiyou9
Copy link

aiyou9 commented May 13, 2024

so quick nice work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
3 participants