Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: track doc create action in bs editor #6915

Merged

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented May 13, 2024

fix TOV-855

added shape element create & doc create event tracking in blocksuite editor.
What's still missing:
the control (source) that triggered whiteboard element creation, i.e., from canvas dbclick, dnd or pasting.

Copy link

graphite-app bot commented May 13, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Collaborator Author

pengx17 commented May 13, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @pengx17 and the rest of your teammates on Graphite Graphite

@pengx17 pengx17 marked this pull request as ready for review May 13, 2024 13:42
Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.65%. Comparing base (48de982) to head (dd45c80).

Additional details and impacted files
@@           Coverage Diff           @@
##           canary    #6915   +/-   ##
=======================================
  Coverage   66.65%   66.65%           
=======================================
  Files         582      582           
  Lines       27184    27184           
  Branches     2535     2535           
=======================================
  Hits        18119    18119           
  Misses       8797     8797           
  Partials      268      268           
Flag Coverage Δ
server-test 77.22% <ø> (ø)
unittest 40.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pengx17 pengx17 force-pushed the xp/05-13-chore_track_doc_create_action_in_bs_editor branch from c6f5ecc to e73ca9d Compare May 13, 2024 14:08
Copy link

graphite-app bot commented May 14, 2024

Merge activity

Brooooooklyn pushed a commit that referenced this pull request May 14, 2024
fix TOV-855

added shape element create & doc create event tracking in blocksuite editor.
What's still missing:
the control (source) that triggered whiteboard element creation, i.e., from canvas dbclick, dnd or pasting.
@Brooooooklyn Brooooooklyn force-pushed the xp/05-13-chore_track_doc_create_action_in_bs_editor branch from e73ca9d to 576d8d7 Compare May 14, 2024 05:32
fix TOV-855

added shape element create & doc create event tracking in blocksuite editor.
What's still missing:
the control (source) that triggered whiteboard element creation, i.e., from canvas dbclick, dnd or pasting.
@Brooooooklyn Brooooooklyn force-pushed the xp/05-13-chore_track_doc_create_action_in_bs_editor branch from 576d8d7 to dd45c80 Compare May 14, 2024 05:35
@graphite-app graphite-app bot merged commit dd45c80 into canary May 14, 2024
32 checks passed
@graphite-app graphite-app bot deleted the xp/05-13-chore_track_doc_create_action_in_bs_editor branch May 14, 2024 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

2 participants