Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(electron): add index for updates #6951

Merged
merged 1 commit into from
May 16, 2024

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented May 15, 2024

image.png

Above image shows the performance on querying a 20k rows of updates table, which is super slow at 150+ms. After adding index for doc_id the performance should be greatly improved.

After:
image.png

fix TOV-866

Copy link

graphite-app bot commented May 15, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@pengx17 pengx17 requested a review from Brooooooklyn May 15, 2024 15:48
@pengx17 pengx17 marked this pull request as ready for review May 15, 2024 15:48
Copy link
Collaborator Author

pengx17 commented May 15, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @pengx17 and the rest of your teammates on Graphite Graphite

@pengx17 pengx17 requested a review from EYHN May 15, 2024 15:48
@github-actions github-actions bot added app:electron Related to electron app rust mod:native labels May 15, 2024
Copy link

codecov bot commented May 15, 2024

Codecov Report

Attention: Patch coverage is 12.19512% with 180 lines in your changes are missing coverage. Please review.

Project coverage is 66.68%. Comparing base (37cb5b8) to head (27af9b4).

Files Patch % Lines
packages/frontend/native/index.js 8.10% 136 Missing ⚠️
...end/electron/src/helper/db/workspace-db-adapter.ts 25.00% 26 Missing and 1 partial ⚠️
...ages/frontend/electron/src/helper/db/db-adapter.ts 19.04% 16 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #6951      +/-   ##
==========================================
- Coverage   66.77%   66.68%   -0.10%     
==========================================
  Files         582      582              
  Lines       27304    27345      +41     
  Branches     2555     2559       +4     
==========================================
+ Hits        18232    18234       +2     
- Misses       8803     8841      +38     
- Partials      269      270       +1     
Flag Coverage Δ
server-test 77.32% <ø> (ø)
unittest 40.13% <12.19%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pengx17 pengx17 force-pushed the xp/05-15-perf_electron_add_index_for_updates branch from 087214f to e2ca790 Compare May 16, 2024 03:45
@pengx17 pengx17 force-pushed the xp/05-15-perf_electron_add_index_for_updates branch from e2ca790 to a206cfa Compare May 16, 2024 04:42
@pengx17 pengx17 force-pushed the xp/05-15-perf_electron_add_index_for_updates branch from a206cfa to 588fa7d Compare May 16, 2024 06:11
Copy link

graphite-app bot commented May 16, 2024

Merge activity

![image.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/T2klNLEk0wxLh4NRDzhk/cd2e982a-f78a-4cc3-b090-ee4c0090e19d.png)

Above image shows the performance on querying a 20k rows of updates table, which is super slow at 150+ms. After adding index for doc_id the performance should be greatly improved.

After:
![image.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/T2klNLEk0wxLh4NRDzhk/45ea4389-1833-4dc5-bd64-84d8c99cd647.png)

fix TOV-866
@Brooooooklyn Brooooooklyn force-pushed the xp/05-15-perf_electron_add_index_for_updates branch from 588fa7d to 27af9b4 Compare May 16, 2024 06:31
@graphite-app graphite-app bot merged commit 27af9b4 into canary May 16, 2024
32 checks passed
@graphite-app graphite-app bot deleted the xp/05-15-perf_electron_add_index_for_updates branch May 16, 2024 06:42
@EYHN EYHN mentioned this pull request May 20, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

2 participants