Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server): use native tokenizer impl #6960

Merged
merged 1 commit into from
May 16, 2024

Conversation

Brooooooklyn
Copy link
Member

Benchmark

yarn workspace @affine/server-native bench

┌─────────┬────────────┬─────────┬────────────────────┬──────────┬─────────┐
│ (index) │ Task Name  │ ops/sec │ Average Time (ns)  │ Margin   │ Samples │
├─────────┼────────────┼─────────┼────────────────────┼──────────┼─────────┤
│ 0       │ 'tiktoken' │ '5'     │ 176932518.76000002 │ '±4.71%' │ 100     │
│ 1       │ 'native'   │ '16'    │ 61041597.51000003  │ '±0.60%' │ 100     │
└─────────┴────────────┴─────────┴────────────────────┴──────────┴─────────┘

Copy link

graphite-app bot commented May 16, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Brooooooklyn and the rest of your teammates on Graphite Graphite

@Brooooooklyn Brooooooklyn force-pushed the 05-15-feat_server_use_native_tokenizer_impl branch from 0fcf93f to bf12bbf Compare May 16, 2024 07:08
@Brooooooklyn Brooooooklyn force-pushed the 05-15-feat_server_use_native_tokenizer_impl branch from bf12bbf to ec77e21 Compare May 16, 2024 07:14
Copy link

codecov bot commented May 16, 2024

Codecov Report

Attention: Patch coverage is 55.00000% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 66.58%. Comparing base (4614003) to head (c7ddd67).

Files Patch % Lines
...ckages/backend/server/src/plugins/copilot/types.ts 50.00% 4 Missing ⚠️
packages/backend/server/src/native.ts 60.00% 2 Missing ⚠️
...kages/backend/server/src/plugins/copilot/prompt.ts 50.00% 2 Missing ⚠️
...ages/backend/server/src/plugins/copilot/session.ts 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #6960      +/-   ##
==========================================
- Coverage   66.65%   66.58%   -0.07%     
==========================================
  Files         582      582              
  Lines       27392    27384       -8     
  Branches     2573     2572       -1     
==========================================
- Hits        18257    18233      -24     
- Misses       8865     8881      +16     
  Partials      270      270              
Flag Coverage Δ
server-test 77.33% <55.00%> (-0.09%) ⬇️
unittest 39.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented May 16, 2024

Merge activity

### Benchmark

`yarn workspace @affine/server-native bench`

```
┌─────────┬────────────┬─────────┬────────────────────┬──────────┬─────────┐
│ (index) │ Task Name  │ ops/sec │ Average Time (ns)  │ Margin   │ Samples │
├─────────┼────────────┼─────────┼────────────────────┼──────────┼─────────┤
│ 0       │ 'tiktoken' │ '5'     │ 176932518.76000002 │ '±4.71%' │ 100     │
│ 1       │ 'native'   │ '16'    │ 61041597.51000003  │ '±0.60%' │ 100     │
└─────────┴────────────┴─────────┴────────────────────┴──────────┴─────────┘
```
@Brooooooklyn Brooooooklyn force-pushed the 05-15-feat_server_use_native_tokenizer_impl branch from ec77e21 to c7ddd67 Compare May 16, 2024 07:55
@graphite-app graphite-app bot merged commit c7ddd67 into canary May 16, 2024
32 checks passed
@graphite-app graphite-app bot deleted the 05-15-feat_server_use_native_tokenizer_impl branch May 16, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

2 participants