Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): fix active view with mouse #6994

Merged
merged 1 commit into from
May 20, 2024

Conversation

EYHN
Copy link
Member

@EYHN EYHN commented May 20, 2024

No description provided.

Copy link

graphite-app bot commented May 20, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@EYHN EYHN marked this pull request as ready for review May 20, 2024 08:06
Copy link
Member Author

EYHN commented May 20, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @EYHN and the rest of your teammates on Graphite Graphite

@EYHN EYHN requested review from JimmFly and pengx17 May 20, 2024 08:07
Copy link

nx-cloud bot commented May 20, 2024

Copy link

codecov bot commented May 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 67.53%. Comparing base (df73b6d) to head (7fddd14).

Files Patch % Lines
...core/src/modules/workbench/view/workbench-root.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #6994      +/-   ##
==========================================
- Coverage   67.59%   67.53%   -0.07%     
==========================================
  Files         584      584              
  Lines       28353    28353              
  Branches     2589     2588       -1     
==========================================
- Hits        19166    19147      -19     
- Misses       8916     8935      +19     
  Partials      271      271              
Flag Coverage Δ
server-test 78.37% <ø> (-0.09%) ⬇️
unittest 39.39% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented May 20, 2024

Merge activity

@EYHN EYHN force-pushed the eyhn/fix/split-view-active branch from 9f3b825 to 7fddd14 Compare May 20, 2024 08:20
@graphite-app graphite-app bot merged commit 7fddd14 into canary May 20, 2024
32 checks passed
@graphite-app graphite-app bot deleted the eyhn/fix/split-view-active branch May 20, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants