Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(electron): always save one update to electron #7009

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented May 21, 2024

not sure do we still need this one

Copy link

graphite-app bot commented May 21, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@pengx17 pengx17 requested a review from EYHN May 21, 2024 11:22
Copy link
Collaborator Author

pengx17 commented May 21, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @pengx17 and the rest of your teammates on Graphite Graphite

Copy link

codecov bot commented May 21, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 67.46%. Comparing base (f50e240) to head (fdc33bd).

Files Patch % Lines
...end/electron/src/helper/db/workspace-db-adapter.ts 16.66% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #7009      +/-   ##
==========================================
- Coverage   67.47%   67.46%   -0.01%     
==========================================
  Files         584      584              
  Lines       28381    28385       +4     
  Branches     2589     2589              
==========================================
  Hits        19151    19151              
- Misses       8959     8963       +4     
  Partials      271      271              
Flag Coverage Δ
server-test 78.32% <ø> (ø)
unittest 39.33% <16.66%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EYHN EYHN force-pushed the xp/05-21-fix_electron_trim_issue branch from 907e933 to 96cdb04 Compare May 21, 2024 13:53
@EYHN EYHN changed the base branch from xp/05-21-fix_electron_trim_issue to canary May 21, 2024 14:19
@EYHN
Copy link
Member

EYHN commented May 22, 2024

According to my testing, performance improved significantly

@pengx17 pengx17 force-pushed the xp/05-21-refactor_electron_always_save_one_update_to_electron branch from b05896d to bcce30e Compare May 22, 2024 04:52
@pengx17 pengx17 marked this pull request as ready for review May 22, 2024 04:54
Copy link

graphite-app bot commented May 22, 2024

Merge activity

  • May 22, 1:03 AM EDT: pengx17 added this pull request to the Graphite merge queue.
  • May 22, 1:14 AM EDT: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: '3, 2, 1 Launch', 'Desktop Test (ubuntu-latest, linux, x64, x86_64-unknown-linux-gnu, true)').
  • May 22, 1:29 AM EDT: pengx17 added this pull request to the Graphite merge queue.
  • May 22, 1:29 AM EDT: pengx17 merged this pull request with the Graphite merge queue.

@pengx17 pengx17 force-pushed the xp/05-21-refactor_electron_always_save_one_update_to_electron branch from bcce30e to fdc33bd Compare May 22, 2024 05:04
@graphite-app graphite-app bot merged commit fdc33bd into canary May 22, 2024
32 checks passed
@graphite-app graphite-app bot deleted the xp/05-21-refactor_electron_always_save_one_update_to_electron branch May 22, 2024 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:electron Related to electron app
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

2 participants