Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): run indexer in worker #7295

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Conversation

EYHN
Copy link
Member

@EYHN EYHN commented Jun 21, 2024

No description provided.

Copy link

graphite-app bot commented Jun 21, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

EYHN commented Jun 21, 2024

Copy link

nx-cloud bot commented Jun 21, 2024

Copy link

codecov bot commented Jun 21, 2024

Codecov Report

Attention: Patch coverage is 10.93750% with 114 lines in your changes missing coverage. Please review.

Project coverage is 57.23%. Comparing base (27d0fc5) to head (c62d79a).

Files Patch % Lines
...e/src/modules/docs-search/entities/docs-indexer.ts 13.69% 58 Missing and 5 partials ⚠️
.../core/src/modules/docs-search/worker/out-worker.ts 2.22% 44 Missing ⚠️
.../common/infra/src/sync/job/impl/indexeddb/index.ts 50.00% 2 Missing ⚠️
.../frontend/core/src/modules/cloud/services/fetch.ts 0.00% 2 Missing ⚠️
packages/common/infra/src/livedata/ops.ts 0.00% 1 Missing ⚠️
packages/common/infra/src/sync/blob/blob.ts 0.00% 1 Missing ⚠️
...re/src/modules/docs-search/services/docs-search.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                                    Coverage Diff                                     @@
##           eyhn/refactor/use-new-indexer-for-backlink_split_split    #7295      +/-   ##
==========================================================================================
+ Coverage                                                   57.17%   57.23%   +0.05%     
==========================================================================================
  Files                                                         901      902       +1     
  Lines                                                       39423    39401      -22     
  Branches                                                     4435     4417      -18     
==========================================================================================
+ Hits                                                        22542    22552      +10     
+ Misses                                                      16534    16497      -37     
- Partials                                                      347      352       +5     
Flag Coverage Δ
server-test 77.91% <ø> (ø)
unittest 28.94% <10.93%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EYHN EYHN force-pushed the eyhn/make-indexer-worker branch from ebf26ba to 81e12d3 Compare June 21, 2024 03:38
@EYHN EYHN changed the base branch from eyhn/refactor/use-new-indexer-for-backlink to eyhn/refactor/use-new-indexer-for-backlink_split_split June 21, 2024 03:38
@EYHN EYHN force-pushed the eyhn/refactor/use-new-indexer-for-backlink_split_split branch from c2f636b to 22bb7d9 Compare June 23, 2024 05:20
@EYHN EYHN force-pushed the eyhn/make-indexer-worker branch from 81e12d3 to 32a7baa Compare June 24, 2024 03:05
@EYHN EYHN force-pushed the eyhn/refactor/use-new-indexer-for-backlink_split_split branch from 22bb7d9 to 7da7a55 Compare June 24, 2024 09:35
@EYHN EYHN force-pushed the eyhn/make-indexer-worker branch 2 times, most recently from 802613c to f7b5192 Compare June 24, 2024 09:44
@EYHN EYHN marked this pull request as ready for review June 24, 2024 09:46
@EYHN EYHN force-pushed the eyhn/refactor/use-new-indexer-for-backlink_split_split branch from 893456a to 1974ab4 Compare June 24, 2024 14:32
@EYHN EYHN force-pushed the eyhn/make-indexer-worker branch from 62e13cf to c7d85c6 Compare June 24, 2024 14:32
@EYHN EYHN force-pushed the eyhn/refactor/use-new-indexer-for-backlink_split_split branch from 1974ab4 to 43aa879 Compare June 24, 2024 14:33
@EYHN EYHN force-pushed the eyhn/make-indexer-worker branch from c7d85c6 to d892b24 Compare June 24, 2024 14:33
@EYHN EYHN force-pushed the eyhn/refactor/use-new-indexer-for-backlink_split_split branch from 43aa879 to 7bad6ca Compare July 1, 2024 05:39
@EYHN EYHN force-pushed the eyhn/make-indexer-worker branch from d892b24 to 02b1afa Compare July 1, 2024 05:39
@EYHN EYHN force-pushed the eyhn/refactor/use-new-indexer-for-backlink_split_split branch from 7bad6ca to f42bd3b Compare July 1, 2024 09:08
@EYHN EYHN force-pushed the eyhn/make-indexer-worker branch 2 times, most recently from de26e49 to f7830fb Compare July 1, 2024 09:09
Copy link

graphite-app bot commented Jul 2, 2024

Merge activity

@forehalo forehalo force-pushed the eyhn/refactor/use-new-indexer-for-backlink_split_split branch from f42bd3b to 2d4d20d Compare July 2, 2024 09:11
forehalo pushed a commit that referenced this pull request Jul 2, 2024
@forehalo forehalo force-pushed the eyhn/refactor/use-new-indexer-for-backlink_split_split branch from 2d4d20d to 27d0fc5 Compare July 2, 2024 09:20
@forehalo forehalo changed the base branch from eyhn/refactor/use-new-indexer-for-backlink_split_split to canary July 2, 2024 09:41
@graphite-app graphite-app bot merged commit c62d79a into canary Jul 2, 2024
31 checks passed
@graphite-app graphite-app bot deleted the eyhn/make-indexer-worker branch July 2, 2024 09:41
forehalo added a commit that referenced this pull request Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core mod:env mod:infra Environment related issues and discussions
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

3 participants