Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: click continue with ai not work #7374

Merged
merged 2 commits into from
Jun 28, 2024
Merged

Conversation

regischen
Copy link
Member

No description provided.

Copy link

graphite-app bot commented Jun 28, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @regischen and the rest of your teammates on Graphite Graphite

@regischen regischen requested a review from fundon June 28, 2024 06:28
@regischen regischen marked this pull request as ready for review June 28, 2024 06:28
Copy link

nx-cloud bot commented Jun 28, 2024

Copy link

codecov bot commented Jun 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 58.27%. Comparing base (eca484d) to head (1f38262).
Report is 1 commits behind head on canary.

Files Patch % Lines
...src/blocksuite/presets/ai/chat-panel/chat-cards.ts 0.00% 2 Missing ⚠️
...suite/presets/ai/chat-panel/chat-panel-messages.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           canary    #7374       +/-   ##
===========================================
+ Coverage   28.34%   58.27%   +29.92%     
===========================================
  Files         654      854      +200     
  Lines       14938    37705    +22767     
  Branches     2626     4081     +1455     
===========================================
+ Hits         4234    21971    +17737     
- Misses      10460    15440     +4980     
- Partials      244      294       +50     
Flag Coverage Δ
server-test 77.91% <ø> (?)
unittest 28.34% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Jun 28, 2024

Merge activity

@forehalo forehalo merged commit f4f84d2 into canary Jun 28, 2024
32 checks passed
@forehalo forehalo deleted the fix-continue-with-ai-click branch June 28, 2024 06:43
Copy link
Collaborator

@pengx17 pengx17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bug should be caused by temporaryParams here.
We'd better not let affine to directly access chat panels' internal value in run time. A proper solution might be exposed through the ChatPanel's interface.

Copy link
Member Author

The bug should be caused by temporaryParams here.
We'd better not let affine to directly access chat panels' internal value in run time. A proper solution might be exposed through the ChatPanel's interface.

The bug is because the handler is in chat-cards component, but it is not rendered when there are histories.

@fundon
Copy link
Contributor

fundon commented Jun 28, 2024

This is a workaround.

There should be a better solution, can we use localstorage for temporary storage?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

6 participants