Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please enhance the effectiveness of the search results in the quick search panel #5699

Closed
1 task
hwangdev97 opened this issue Jan 25, 2024 · 2 comments · Fixed by #5722
Closed
1 task

Please enhance the effectiveness of the search results in the quick search panel #5699

hwangdev97 opened this issue Jan 25, 2024 · 2 comments · Fixed by #5722
Assignees
@pengx17
Labels
story Features perceivable by end-users

Comments

@hwangdev97
Copy link
Member

Description

shot-2024-01-25-14 28 29@2x

I think we need to display the results matching 'aff' first. Also, I suggest that the number of document results should be limited to less than 10.

Use case

No response

Anything else?

No response

Are you willing to submit a PR?

  • Yes I'd like to help by submitting a PR!
@hwangdev97 hwangdev97 added the story Features perceivable by end-users label Jan 25, 2024
@pengx17 pengx17 mentioned this issue Jan 26, 2024
Merged
@keerthi5465
Copy link

Can i work on it

pengx17 added a commit that referenced this issue Feb 16, 2024
@pengx17
refactor(component): cmdk ordering (#5722)
d1c4e61 
Replace internal CMDK command filtering/sorting logic.
The new implementation includes the following for command scoring:
- categories weights
- highlighted fragments
- original command score value

The new logic should be much cleaner and remove some hacks in the original implementation.

Not sure if this is optimal yet. Could be changed later.

fix #5699
@EYHN
Copy link
Member

EYHN commented Feb 22, 2024

fixed in #5722

@EYHN EYHN closed this as completed Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pengx17 pengx17

Labels
story Features perceivable by end-users
Projects
AFFiNE Project
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(component): cmdk ordering toeverything/AFFiNE
4 participants
@pengx17 @EYHN @hwangdev97 @keerthi5465