Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(component): cmdk ordering #5722

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Jan 26, 2024

Replace internal CMDK command filtering/sorting logic.
The new implementation includes the following for command scoring:

  • categories weights
  • highlighted fragments
  • original command score value

The new logic should be much cleaner and remove some hacks in the original implementation.

Not sure if this is optimal yet. Could be changed later.

fix #5699

Copy link

graphite-app bot commented Jan 26, 2024

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

Copy link
Collaborator Author

pengx17 commented Jan 26, 2024

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@github-actions github-actions bot added mod:infra Environment related issues and discussions test Related to test cases app:core labels Jan 26, 2024
Copy link

codecov bot commented Jan 26, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (9e7eb56) 65.19% compared to head (d1c4e61) 46.78%.

Files Patch % Lines
...d/core/src/components/pure/cmdk/filter-commands.ts 84.61% 2 Missing and 4 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           canary    #5722       +/-   ##
===========================================
- Coverage   65.19%   46.78%   -18.41%     
===========================================
  Files         347      215      -132     
  Lines       19624     4972    -14652     
  Branches     1649      886      -763     
===========================================
- Hits        12793     2326    -10467     
+ Misses       6611     2456     -4155     
+ Partials      220      190       -30     
Flag Coverage Δ
server-test ?
unittest 46.78% <85.36%> (+0.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pengx17 pengx17 force-pushed the xp/01-26-refactor_component_cmdk_ordering branch from 274f928 to a18a5d7 Compare January 26, 2024 08:48
@pengx17 pengx17 force-pushed the xp/01-26-refactor_component_cmdk_ordering branch from a18a5d7 to 7b1b292 Compare January 26, 2024 09:51
@pengx17 pengx17 force-pushed the xp/01-26-refactor_component_cmdk_ordering branch 6 times, most recently from 14fb5dd to 9c300da Compare February 2, 2024 10:41
@pengx17 pengx17 force-pushed the xp/01-26-refactor_component_cmdk_ordering branch from 9c300da to b6f211f Compare February 13, 2024 14:37
Copy link

nx-cloud bot commented Feb 13, 2024

@pengx17 pengx17 force-pushed the xp/01-26-refactor_component_cmdk_ordering branch from b6f211f to f70e4f7 Compare February 16, 2024 13:08
Copy link

graphite-app bot commented Feb 16, 2024

Merge activity

Replace internal CMDK command filtering/sorting logic.
The new implementation includes the following for command scoring:
- categories weights
- highlighted fragments
- original command score value

The new logic should be much cleaner and remove some hacks in the original implementation.

Not sure if this is optimal yet. Could be changed later.

fix #5699
@pengx17 pengx17 force-pushed the xp/01-26-refactor_component_cmdk_ordering branch from f70e4f7 to d1c4e61 Compare February 16, 2024 13:20
@graphite-app graphite-app bot merged commit d1c4e61 into canary Feb 16, 2024
38 of 42 checks passed
@graphite-app graphite-app bot deleted the xp/01-26-refactor_component_cmdk_ordering branch February 16, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core app:server mod:infra Environment related issues and discussions test Related to test cases
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Please enhance the effectiveness of the search results in the quick search panel
2 participants