refactor(component): cmdk ordering #5722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into canaryYou must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. You can enable merging using labels in your Graphite merge queue settings. |
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
github-actions
bot
added
mod:infra
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## canary #5722 +/- ##
===========================================
- Coverage 65.19% 46.78% -18.41%
===========================================
Files 347 215 -132
Lines 19624 4972 -14652
Branches 1649 886 -763
===========================================
- Hits 12793 2326 -10467
+ Misses 6611 2456 -4155
+ Partials 220 190 -30
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pengx17
force-pushed
the
xp/01-26-refactor_component_cmdk_ordering
branch
from
274f928
to
a18a5d7
Compare
JimmFly
approved these changes
Jan 26, 2024
pengx17
force-pushed
the
xp/01-26-refactor_component_cmdk_ordering
branch
from
a18a5d7
to
7b1b292
Compare
pengx17
force-pushed
the
xp/01-26-refactor_component_cmdk_ordering
branch
6 times, most recently
from
14fb5dd
to
9c300da
Compare
pengx17
force-pushed
the
xp/01-26-refactor_component_cmdk_ordering
branch
from
9c300da
to
b6f211f
Compare
☁️ Nx Cloud ReportCI is running/has finished running commands for commit d1c4e61. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
pengx17
force-pushed
the
xp/01-26-refactor_component_cmdk_ordering
branch
from
b6f211f
to
f70e4f7
Compare
Merge activity
|
Replace internal CMDK command filtering/sorting logic. The new implementation includes the following for command scoring: - categories weights - highlighted fragments - original command score value The new logic should be much cleaner and remove some hacks in the original implementation. Not sure if this is optimal yet. Could be changed later. fix #5699
pengx17
force-pushed
the
xp/01-26-refactor_component_cmdk_ordering
branch
from
f70e4f7
to
d1c4e61
Compare
graphite-app
bot
deleted the
xp/01-26-refactor_component_cmdk_ordering
branch
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace internal CMDK command filtering/sorting logic.
The new implementation includes the following for command scoring:
The new logic should be much cleaner and remove some hacks in the original implementation.
Not sure if this is optimal yet. Could be changed later.
fix #5699