Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugs]​ The icon's problem #6212

Closed
1 task
zxp19821005 opened this issue Mar 20, 2024 · 6 comments
Closed
1 task

[Bugs]​ The icon's problem #6212

zxp19821005 opened this issue Mar 20, 2024 · 6 comments
Assignees

Comments

@zxp19821005
Copy link

What happened?

The icons in the packaged Linux AppImage was Electron!

Distribution version

Linux

What browsers are you seeing the problem on if you're using web version?

No response

Are you self-hosting?

  • Yes

Relevant log output

No response

Anything else?

No response

@affine-issue-bot
Copy link

affine-issue-bot bot commented Mar 20, 2024

Issue Status: ✅ Done

✅ Done

If the issue was a bug, it’s been fixed; if it was a missing feature, it’s been implemented.

This is an automatic reply by the bot.

@CatsJuice
Copy link
Member

Is this fixed? @pengx17

@pengx17
Copy link
Collaborator

pengx17 commented Mar 20, 2024

Not yet. It looks like to be some restrictions to AppImage related to icons.
I guess this can be solved by using other more desktop friendly solutions like flatpak. Still working on it right now.

@zxp19821005
Copy link
Author

@pengx17
Copy link
Collaborator

pengx17 commented Mar 20, 2024

I think you should check this : canary/packages/frontend/electron/forge.config.mjs

AFIAK to show the icon in the filesystem (in the file explorer ui) a daemon process is required (like https://github.com/probonopd/go-appimage).
To show the correct icon in the app tray it says that we can call setIcon when app is running - however it did not successfully worked in my last try. Will take a look later.

@pengx17
Copy link
Collaborator

pengx17 commented Mar 21, 2024

fixed in #6257

@pengx17 pengx17 closed this as completed Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

3 participants