fix: flaky float number asserter

toeverything · Dec 20, 2022 · 294e5b3 · 294e5b3 · vercel · Dec 20, 2022
1 parent 4db6e0d
commit 294e5b3
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 4 deletions.
diff --git a/tests/selection.spec.ts b/tests/selection.spec.ts
@@ -29,6 +29,7 @@ import {
   assertBlockCount,
   assertRichTexts,
   assertSelection,
+  assertAlmostEqual,
 } from './utils/asserts';
 
 test('click on blank area', async ({ page }) => {
@@ -545,10 +546,10 @@ test('selection on heavy page', async ({ page }) => {
         const rect = await page
           .locator('.affine-page-frame-selection-rect')
           .evaluate(element => element.getBoundingClientRect());
-        expect(rect.x).toBe(first.x - 1);
-        expect(rect.y).toBe(first.y - 1);
-        expect(rect.right).toBe(last.x + 1);
-        expect(rect.bottom).toBe(last.y + 1);
+        assertAlmostEqual(rect.x, first.x - 1, 1);
+        assertAlmostEqual(rect.y, first.y - 1, 1);
+        assertAlmostEqual(rect.right, last.x + 1, 1);
+        assertAlmostEqual(rect.bottom, last.y + 1, 1);
       },
     }
   );

diff --git a/tests/utils/asserts.ts b/tests/utils/asserts.ts
@@ -394,3 +394,11 @@ export async function assertClipItems(page: Page, key: string, value: unknown) {
   const actual = clipItems.find(item => item.mimeType === key)?.data;
   expect(actual).toEqual(value);
 }
+
+export function assertAlmostEqual(
+  actual: number,
+  expected: number,
+  precision = 0.001
+) {
+  expect(Math.abs(actual - expected)).toBeLessThan(precision);
+}