Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please support the Delete key to function the same way as the Backspace key. #2550

Closed
1 task done
Alkaidcc opened this issue May 12, 2023 · 2 comments · Fixed by #2552
Closed
1 task done

Please support the Delete key to function the same way as the Backspace key. #2550

Alkaidcc opened this issue May 12, 2023 · 2 comments · Fixed by #2552
Assignees
@lawvs
Labels
beta Issues should be fixed for current Beta release. good first issue Good for newcomers mod:hotkey Module: related to hotkey binding type:bug Something isn't working
Milestone
AFFiNE 0.7

Comments

@Alkaidcc
Copy link
Contributor

Alkaidcc commented May 12, 2023 •
edited

What happened?

reproduction video as below.

2023-05-12.09.23.34.mov

Version

macOS x64

What browsers are you seeing the problem on?

No response

Relevant log output

No response

Anything else?

AFFINE should support Delete key to allow user delete their blocks
version: 0.6.0-canary.0

Are you willing to submit a PR?

  • Yes I'd like to help by submitting a PR!
@Alkaidcc Alkaidcc added the type:bug Something isn't working label May 12, 2023
@lawvs lawvs transferred this issue from toeverything/AFFiNE May 12, 2023
@lawvs lawvs added mod:hotkey Module: related to hotkey binding good first issue Good for newcomers labels May 12, 2023
@affine-bot
Copy link

Hello! Thank you for filing an issue.
If this is a bug report, please include relevant logs to help us debug the problem.

Alkaidcc added a commit to Alkaidcc/blocksuite that referenced this issue May 12, 2023
@Alkaidcc
feat(blocks): support delete hotkey fix toeverything#2550
314d942
@Alkaidcc Alkaidcc mentioned this issue May 12, 2023
Merged
@doodlewind doodlewind mentioned this issue Jun 13, 2023
Closed
@doodlewind doodlewind added the beta Issues should be fixed for current Beta release. label Jun 13, 2023
@doodlewind
Copy link
Member

/cc @lawvs this needs to be prioritized due to recent operations feedback, could you help with the landing of relevant PR? Thanks!

@doodlewind doodlewind added this to the AFFiNE 0.7 milestone Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lawvs lawvs

Labels
beta Issues should be fixed for current Beta release. good first issue Good for newcomers mod:hotkey Module: related to hotkey binding type:bug Something isn't working
Projects
AFFiNE Project
Archived in project
BlockSuite Project
Archived in project
Milestone
AFFiNE 0.7
Development

Successfully merging a pull request may close this issue.

feat(blocks): support delete hotkey Alkaidcc/blocksuite
4 participants
@doodlewind @lawvs @Alkaidcc @affine-bot