Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ClipboardManager to blocks package #305

Closed
Tracked by #1439 ...
doodlewind opened this issue Dec 14, 2022 · 4 comments
Closed
Tracked by #1439 ...

Move ClipboardManager to blocks package #305

doodlewind opened this issue Dec 14, 2022 · 4 comments
Labels
mod:clipboard Module: related to clipboard type:refactor Refactoring on codebase

Comments

@doodlewind
Copy link
Member

We can migrate ClipboardManager to BlockHost.clipboard. This solves the problem of calling clipboard APIs from the blocks package and aligns more with our goal to build more editor modes as "block container" in @blocksuite/blocks. Ultimately the @blocksuite/editor package will be mainly a thin wrapper of different block containers (default page block, edgeless page block, mobile page block, etc.).

Also, this resolves the OpenBlockInfo conflicts.

It's a nice-to-have improvement. We can wait until the next housekeeping cleanup after our December release if we have a decent workaround.

cc @DiamondThree @zuoxiaodong0815

@DiamondThree
Copy link
Contributor

DiamondThree commented Dec 15, 2022

So, should we now migrate or keep the status quo rather? I don't know if relocating will cause some other problems, for example, the previous call site will fail, Maybe need @zuoxiaodong0815 to tell me.

@doodlewind
Copy link
Member Author

So, should we now migrate or keep the status quo rather? I don't know if relocating will cause some other problems, for example, the previous call site will fail, Maybe need @zuoxiaodong0815 to tell me.

Our discussion estimated that it may take a few days for the migration, so it would be fine to postpone this task for now.

@DiamondThree
Copy link
Contributor

ok, I get

@doodlewind doodlewind added the mod:clipboard Module: related to clipboard label Jan 9, 2023
@doodlewind doodlewind added the type:refactor Refactoring on codebase label Feb 10, 2023
@QiShaoXuan QiShaoXuan mentioned this issue Mar 1, 2023
12 tasks
@doodlewind
Copy link
Member Author

Closed by #1687

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mod:clipboard Module: related to clipboard type:refactor Refactoring on codebase
Projects
Archived in project
Development

No branches or pull requests

2 participants