Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor clipboard #1687

Merged
merged 4 commits into from
Mar 14, 2023

Conversation

QiShaoXuan
Copy link
Contributor

@QiShaoXuan QiShaoXuan commented Mar 13, 2023

This continues from 1439

Related Issues

Roadmap

  • Migrate clipboard from editor file to blocks file
  • Support copy&cut
    • Store the clipboard instance under block-host
    • page and edgeless clipboard are instantiated and stored in their respective hosts, sharing common functions
    • Add block2html, block2Text, block2Json to block-service, block conversion clipboard to be managed by block instead of Clipboard
  • Support paste
    • Add json2block to block-service
  • Refactor origin copy function, copyImagecopyCode and so on
  • FIx test case

Workflow

clipboard-work-flow

TODO

These todo items will process in next stage

  • refactor content parser
  • refactor file exporter

@codesandbox
Copy link

codesandbox bot commented Mar 13, 2023

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@vercel
Copy link

vercel bot commented Mar 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 14, 2023 at 8:24AM (UTC)
blocksuite-react ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 14, 2023 at 8:24AM (UTC)

@QiShaoXuan QiShaoXuan marked this pull request as ready for review March 13, 2023 15:16
@QiShaoXuan QiShaoXuan enabled auto-merge (squash) March 13, 2023 15:16
@QiShaoXuan QiShaoXuan merged commit ed7a9fd into toeverything:master Mar 14, 2023
@doodlewind doodlewind added the breaking Contains breaking change that must be addressed label Mar 14, 2023
fundon added a commit to fundon/blocksuite that referenced this pull request Mar 14, 2023
…find-block

* master:
  feat: refactor clipboard (toeverything#1687)
  fix(virgo): render error in title when first charaster is space (toeverything#1692)
  test(virgo): fix virgo test (toeverything#1693)
@QiShaoXuan QiShaoXuan deleted the feat/refactor-clipboard branch March 15, 2023 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Contains breaking change that must be addressed
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants