Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong background color on copied PNG in edgeless mode #3489

Closed
Yipei-Operation opened this issue Jul 12, 2023 · 4 comments · Fixed by #3502
Closed

Wrong background color on copied PNG in edgeless mode #3489

Yipei-Operation opened this issue Jul 12, 2023 · 4 comments · Fixed by #3502
Assignees
@zuoxiaodong0815
Labels
beta Issues should be fixed for current Beta release. fatal Bugs with highest priority mod:clipboard Module: related to clipboard type:bug Something isn't working
Milestone
AFFiNE 0.7

Comments

@Yipei-Operation
Copy link

version: latest internal (both 711/712 version)
system: macOS

  1. when change the block color, then choose to 「copy as PNG」
  2. the PNG will shown mistake: all background color is blue
copy.as.png.issue.mp4
@Yipei-Operation Yipei-Operation added fatal Bugs with highest priority beta Issues should be fixed for current Beta release. labels Jul 12, 2023
@doodlewind doodlewind added type:bug Something isn't working mod:clipboard Module: related to clipboard labels Jul 12, 2023
@doodlewind doodlewind changed the title copy as PNG issue 1: background color has mistake Wrong background color on copied PNG in edgeless mode Jul 12, 2023
@xell
Copy link
Contributor

xell commented Jul 12, 2023

According to @zuoxiaodong0815 , the output result directly from the code is correct, so we'll see if it's not cherry picked to the release by @alex. C.f. #3293

@doodlewind
Copy link
Member

@Yipei-Operation not sure if you think this is a fatal one?

@Yipei-Operation
Copy link
Author

I think this is a fatal one, as 「copy as PNG」 is a common function, it is more common than exported scenes

@zuoxiaodong0815 zuoxiaodong0815 mentioned this issue Jul 13, 2023
Merged
@zuoxiaodong0815
Copy link
Contributor

close by #3502

@xell xell added this to the AFFiNE 0.7 milestone Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zuoxiaodong0815 zuoxiaodong0815

Labels
beta Issues should be fixed for current Beta release. fatal Bugs with highest priority mod:clipboard Module: related to clipboard type:bug Something isn't working
Projects
AFFiNE Project
Archived in project
BlockSuite Project
Archived in project
Milestone
AFFiNE 0.7
Development

Successfully merging a pull request may close this issue.

fix: copy as png zuoxiaodong0815/blocksuite
4 participants
@xell @doodlewind @zuoxiaodong0815 @Yipei-Operation