-
-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add codeql-analysis.yml
#306
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@lawvs found a REGEX blocker here. It would be great if you could take a look. Thanks! |
OK, I bypassed the scan by splitting the regex :) |
lgtm |
It costs 4min to complete CodeQL check, this slows us down. Can we make it run daily? For future multi-browser E2E testing, this kind of setup should be also useful. |
I think there should have some cache on the following incremental commit? |
Well, let's just try committing some trivial refactoring here and see again 👀 |
I'd say the incremental run speed is still not very satisfying, especially for a check whose report is not our concern in maybe 99% of the time :( I really want to make the CI process faster and easier, lots of effort has been done for reaching the current state. Daily running the CodeQL check seems to be more acceptable, though. |
updated |
Great improvement for our CI, thanks! |
No description provided.