Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add codeql-analysis.yml #306

Merged
merged 4 commits into from
Dec 16, 2022
Merged

Conversation

himself65
Copy link
Contributor

No description provided.

@himself65 himself65 marked this pull request as ready for review December 14, 2022 19:37
@vercel
Copy link

vercel bot commented Dec 14, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
blocksuite ✅ Ready (Inspect) Visit Preview Dec 16, 2022 at 4:35PM (UTC)

@doodlewind
Copy link
Member

@lawvs found a REGEX blocker here. It would be great if you could take a look. Thanks!

@lawvs
Copy link
Member

lawvs commented Dec 16, 2022

OK, I bypassed the scan by splitting the regex :)

@himself65
Copy link
Contributor Author

lgtm

@doodlewind
Copy link
Member

It costs 4min to complete CodeQL check, this slows us down. Can we make it run daily? For future multi-browser E2E testing, this kind of setup should be also useful.

@himself65
Copy link
Contributor Author

It costs 4min to complete CodeQL check, this slows us down. Can we make it run daily? For future multi-browser E2E testing, this kind of setup should be also useful.

I think there should have some cache on the following incremental commit?

@doodlewind
Copy link
Member

It costs 4min to complete CodeQL check, this slows us down. Can we make it run daily? For future multi-browser E2E testing, this kind of setup should be also useful.

I think there should have some cache on the following incremental commit?

Well, let's just try committing some trivial refactoring here and see again 👀

@doodlewind doodlewind added the mod:infra Environment related issues and discussions label Dec 16, 2022
@doodlewind
Copy link
Member

I'd say the incremental run speed is still not very satisfying, especially for a check whose report is not our concern in maybe 99% of the time :(

I really want to make the CI process faster and easier, lots of effort has been done for reaching the current state. Daily running the CodeQL check seems to be more acceptable, though.

@himself65
Copy link
Contributor Author

updated

@doodlewind
Copy link
Member

Great improvement for our CI, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mod:infra Environment related issues and discussions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants