Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: upgrade github actions #360

Merged
merged 1 commit into from
Dec 19, 2022
Merged

ci: upgrade github actions #360

merged 1 commit into from
Dec 19, 2022

Conversation

himself65
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Dec 19, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
blocksuite ✅ Ready (Inspect) Visit Preview Dec 19, 2022 at 1:41AM (UTC)

doodlewind
doodlewind approved these changes Dec 19, 2022
View reviewed changes
Copy link
Member

@doodlewind doodlewind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for maintaining this!

@doodlewind
Copy link
Member

I wonder if we can move the tsc type check part from the Test action to the Lint action. In this case, the Lint action could be renamed' Check'. Based on our current status, this could benefit the time cost of CI.

@doodlewind doodlewind merged commit ec4be37 into toeverything:master Dec 19, 2022
@himself65
Copy link
Contributor Author

I wonder if we can move the tsc type check part from the Test action to the Lint action. In this case, the Lint action could be renamed' Check'. Based on our current status, this could benefit the time cost of CI.

That would possible and we can add cache on that to make it fater

@himself65 himself65 deleted the 20221218-ci branch December 19, 2022 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doodlewind doodlewind doodlewind approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@himself65 @doodlewind