fix: added base UI font family to the Menu of edgeless #3910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
RajeevDash007
changed the title
|
@xell @doodlewind |
doodlewind
approved these changes
Aug 9, 2023
There was a problem hiding this comment.
Thanks for the quick response! It's land-able since CI passes and the patch looks pretty neat, but I'd suggest just keep this open for a while, since we are trying the workflow that for styling issues labeled with mod:style, we await for the design team to verify the effect. So /cc @xell @hwangdev97 to confirm.
xell
approved these changes
Aug 10, 2023
doodlewind
reviewed
Aug 10, 2023
packages/blocks/src/page-block/edgeless/components/component-toolbar/more-button.ts
Show resolved
Hide resolved
|
@doodlewind check #3954 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed: #3781
@xell check this out