Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(edgeless): remove over rendering on mouse move and viewport updates #3911

Merged
merged 12 commits into from
Aug 9, 2023
Merged

perf(edgeless): remove over rendering on mouse move and viewport updates #3911

merged 12 commits into from
Aug 9, 2023

Conversation

regischen
Copy link
Member

@regischen regischen commented Aug 9, 2023 •
edited by doodlewind

Close #3916

@vercel
Copy link

vercel bot commented Aug 9, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 9, 2023 9:35am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Aug 9, 2023 9:35am

@regischen regischen marked this pull request as ready for review August 9, 2023 03:13
@doodlewind doodlewind marked this pull request as draft August 9, 2023 03:50
@regischen regischen marked this pull request as ready for review August 9, 2023 06:42
@doodlewind doodlewind added the notable Major improvement worth emphasizing label Aug 9, 2023
doodlewind
doodlewind approved these changes Aug 9, 2023
View reviewed changes
Copy link
Member

@doodlewind doodlewind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the optimization! We should land this for now, since the perf regression on panning viewport and mouse move has been solved.

But there are still over-rendering in local editing, which can be addressed in following PRs.

Doc mode:

Screen.Recording.2023-08-09.at.19.41.40.mov

Edgeless mode:

Screen.Recording.2023-08-09.at.19.42.07.mov

(Just add a console.log in render method in paragraph block to check the effect).

@doodlewind doodlewind changed the title perf(edgeless): re-render only related parts perf(edgeless): remove over rendering on mouse move and viewport updates Aug 9, 2023
@doodlewind doodlewind merged commit 7c63b69 into master Aug 9, 2023
19 checks passed
@doodlewind doodlewind deleted the perf-edgeless-mousemove branch August 9, 2023 11:47
@regischen
Copy link
Member Author

Thanks for the optimization! We should land this for now, since the perf regression on panning viewport and mouse move has been solved.

But there are still over-rendering in local editing, which can be addressed in following PRs.

Doc mode:

Screen.Recording.2023-08-09.at.19.41.40.mov
Edgeless mode:

Screen.Recording.2023-08-09.at.19.42.07.mov
(Just add a console.log in render method in paragraph block to check the effect).

I see. Hope this can be improved later

@doodlewind doodlewind mentioned this pull request Aug 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doodlewind doodlewind doodlewind approved these changes

Assignees

@regischen regischen

Labels
notable Major improvement worth emphasizing
Projects
AFFiNE Project
Archived in project
BlockSuite Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Redundant re-render in edgeless mode
2 participants
@regischen @doodlewind