Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(edgeless): support moving edgeless elements with arrow keys #4143

Merged
merged 2 commits into from
Aug 16, 2023

Conversation

WBbug
Copy link
Contributor

@WBbug WBbug commented Aug 16, 2023

close #4063

Kapture.2023-08-16.at.18.08.52.mp4

@vercel
Copy link

vercel bot commented Aug 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 16, 2023 10:20am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Aug 16, 2023 10:20am

Copy link

@affine-bot affine-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Thank you for your contribution.

In order for us to review and merge your suggested changes, please sign our CLA at https://github.com/toeverything/blocksuite/edit/master/.github/CLA.md

Copy link
Member

@doodlewind doodlewind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This generally looks good and I can see it also work for connector, thanks for the help!

@doodlewind doodlewind enabled auto-merge (squash) August 16, 2023 10:27
@doodlewind doodlewind added the notable Major improvement worth emphasizing label Aug 16, 2023
@doodlewind doodlewind merged commit 97864d3 into toeverything:master Aug 16, 2023
18 checks passed
@WBbug WBbug deleted the support-arrow-move branch September 8, 2023 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notable Major improvement worth emphasizing
Projects
Archived in project
Archived in project
Development

Successfully merging this pull request may close these issues.

Support moving edgeless elements with arrow keys
3 participants