fix: can not run blocksuite's toast function when not open a page in affine #4236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
doodlewind
reviewed
Aug 21, 2023
There is no corresponding issue yet. I'll create a new issue. |
fourdim
reviewed
Aug 21, 2023
| @@ -174,16 +173,19 @@ export async function importNotion(workspace: Workspace, file: File) { | |||
| let id = 1; | |||
| const titles: string[] = []; | |||
| const rows: string[][] = []; | |||
| tableString?.split('\n').forEach((row, index) => { | |||
| tableString?.split(/\r\n|\r|\n/).forEach((row, index) => { | |||
| const rowArray = row.split(/,\s*(?![^"]*",)/); | |||
There was a problem hiding this comment.
Separated by commas, but ignoring commas within quotes.
There was a problem hiding this comment.
",", ",,", ""
^ ^
What you need to match is two, but you only match one.
There was a problem hiding this comment.
Replaced with this regular /,\s*(?=(?:(?:[^"]"){2})[^"]*$)/ @fourdim
There was a problem hiding this comment.
It's never easy parsing a string. I suggest using libraries like papaparse.
I have created a new issue to relate the pr. @doodlewind |
doodlewind
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #4238
fix: can not run blocksuite's toast function when not open a page in affine
fix: ignore quotes when parsing table