Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(edgeless): prevent unnecessary rerendering #4276

Merged
merged 5 commits into from
Aug 22, 2023
Merged

Conversation

doouding
Copy link
Member

@doouding doouding commented Aug 22, 2023

close #4154

Change

  • directly set will-change rather than trigger an render in lit 'cause it's more efficient
  • no need to update note height when first rendering the note block
  • override hasChanged on block element selected property to prevent unnecessary rerendering

@vercel
Copy link

vercel bot commented Aug 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 22, 2023 9:30am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Aug 22, 2023 9:30am

Copy link
Member

@doodlewind doodlewind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very impressive, thanks!

@doodlewind doodlewind enabled auto-merge (squash) August 22, 2023 09:30
@doodlewind doodlewind merged commit ad0aecf into master Aug 22, 2023
18 checks passed
@doodlewind doodlewind deleted the perf/over_rendering branch August 22, 2023 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notable Major improvement worth emphasizing
Projects
Archived in project
Archived in project
Development

Successfully merging this pull request may close these issues.

Over rendering on editing single paragraph in edgeless
2 participants