-
-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(page): use computePosition for attachment #4291
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
bfe1fd7
to
f3f6471
Compare
f3f6471
to
a3d7cfd
Compare
8d8234c
to
ccfc518
Compare
doodlewind
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3745
Fix #4138
Fix #4028 (part of)
Note that #3744 is not fixed by this PR.
Refactor
attachment options
bookmarklet options
image options
code options
code lang list
API Changes
portal
toblocks/components
(will be move to newcomponents
packages next time)createDelayHoverSignal(Deprecated)createLitPortal
now supportsshodowDom
options, with a default value oftrue
.createLitPortal
tocreateSimplePortal
createLitPortal
with auto update position supportsAlternative Design
Screen.Recording.2023-08-23.at.00.45.26.mov