Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(virgo): add hook and remove bindHandlers #4386

Merged
merged 7 commits into from
Aug 28, 2023

Conversation

Flrande
Copy link
Member

@Flrande Flrande commented Aug 27, 2023

  1. Remove bindHandlers and add hooks to inject Virgo event handler
  2. Use DisposableGroup to manage event listener

Close #3436

@vercel
Copy link

vercel bot commented Aug 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 28, 2023 2:47am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Aug 28, 2023 2:47am

@Flrande Flrande merged commit ae76a2a into toeverything:master Aug 28, 2023
18 checks passed
@Flrande Flrande deleted the virgo/hook-0827 branch August 28, 2023 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Archived in project
Development

Successfully merging this pull request may close these issues.

Remove paste and keydown handlers in Virgo
1 participant