Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove block by slash menu should remove children #4465

Merged
merged 4 commits into from
Aug 30, 2023

Conversation

lawvs
Copy link
Member

@lawvs lawvs commented Aug 30, 2023

  • When using the remove action by slash menu, any associated children should also be removed.
  • The bringChildrenTo: parent will unshift all children to the parent which is confused

Before

Screen.Recording.2023-08-30.at.16.48.51.mov

@vercel
Copy link

vercel bot commented Aug 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2023 9:09am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Aug 30, 2023 9:09am

@lawvs lawvs changed the title fix: remove block by slash menu should not bring chilren to top fix: remove block by slash menu should remove children Aug 30, 2023
@lawvs lawvs requested a review from houjoe0829 August 30, 2023 09:08
@lawvs lawvs merged commit 31bcdda into master Aug 30, 2023
20 checks passed
@lawvs lawvs deleted the fix/unexpected-children-when-remove-block branch August 30, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

1 participant