fix(page): viewport jilter when drag to left-bottom and cannot insert to page bottom from block-hub #4509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
donteatfriedrice
changed the title
doodlewind
approved these changes
Sep 1, 2023
|
Good catch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To close #3684 #3924
This issue caused by legacy doc page check api.
Now the page tagName change to 'AFFINE-DOC-PAGE', but the code still check 'AFFINE-DEFAULT-PAGE', this would let function findBlockElement() return pageBlockElement too, and cause calculate drop target position out of page and jilter, this is incorrect, the findBlockElement() function should only return blockElement.
Now we can insert blank lines without jilter:
Screen.Recording.2023-09-01.at.00.11.17.mov