Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix errors in next.js #4709

Merged
merged 5 commits into from
Sep 24, 2023
Merged

Conversation

yunnian
Copy link
Contributor

@yunnian yunnian commented Sep 11, 2023

fix two errors in next.js:

  1. Part of #3663 document and window is not defined
  2. Unable to build in next.js if throw error , because next.js is prerendered on the server and hydrated on the client.

@vercel
Copy link

vercel bot commented Sep 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 21, 2023 8:48pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Sep 21, 2023 8:48pm

packages/blocks/src/index.ts Outdated Show resolved Hide resolved
packages/editor/src/index.ts Outdated Show resolved Hide resolved
Copy link
Member

@doodlewind doodlewind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the help! Also /cc @sxzz to see if the code snippet provided here could be reused in the ecosystem-ci.

@doodlewind doodlewind merged commit d6f28d0 into toeverything:master Sep 24, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants