Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(edgeless): isolate the impact of widgets on the layout #4738

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

doouding
Copy link
Member

close #4701

@vercel
Copy link

vercel bot commented Sep 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 13, 2023 8:45am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Sep 13, 2023 8:45am

@doouding
Copy link
Member Author

I found that it is the widgets that mainly cause the broken layout of the edgeless mode. I isolate the impact of the widgets on the layout, but not sure if this can solve the whole potential problem.

@doouding doouding marked this pull request as ready for review September 13, 2023 09:16
@doouding doouding changed the title fix: isolate the impact of widget on the layout fix(edgeless): isolate the impact of widgets on the layout Sep 13, 2023
@doouding doouding merged commit dfd0401 into master Sep 13, 2023
22 checks passed
@doouding doouding deleted the fix/edgeless-layout-broken branch September 13, 2023 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Archived in project
Development

Successfully merging this pull request may close these issues.

Edgeless and page switching buttons are missing
2 participants