You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The BlockSuiteRoot component has built a rerender mechanism inside. But, it does not work for edgeless mode cause edgeless wraps everything inside SurfaceBlock which stops the notes that are deep inside the components tree from updating.
I added an extra slot listener to track notes' updates individually.
Is it the content or the position that can't be synchronized? In render, there is root's render method, so theoretically, there should be event listeners.
Both, like when you drag the note or press enter to add a new paragraph. In the previous version (before SurfaceBlockComponent was introduced), everything was placed directly under the EdgelessPageBlockComponent, the rerender works well.
I wonder if there's a better approach to solving this issue.
I think we should merge this pr. Although there may have better solutions, we can improve the implementation later. Anyway, it's a fatal bug. And I think we should add some e2e test for this case.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #4697
The
BlockSuiteRootcomponent has built a rerender mechanism inside. But, it does not work for edgeless mode cause edgeless wraps everything insideSurfaceBlockwhich stops the notes that are deep inside the components tree from updating.I added an extra slot listener to track notes' updates individually.