perf(edgeless): remove edgeless CSS variable to increase performance #4939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
doodlewind
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zoom in/out or change the viewport of the edgeless will update the CSS variables like
--affine-edgeless-x,--affine-edgeless-y,--affine-zoom, and so on. Each time those variables are updated, the browser needs to recalculate all its descendants' styles even if those descendants does not use any of the variable.The solution is simple, remove the variable and just use those values in JavaScript directly.
Before
After
Change
translateX,translateY, andzoomfromedgeless.surface.viewportalong with theedgeless.slots.viewportUpdatedshould be sufficient for most scenarios.