feat(page): safe triangle for whenHover API
#4965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
lawvs
force-pushed
the
feat/safe-triangle
branch
from
44d7c9f
to
4861247
Compare
lawvs
force-pushed
the
feat/safe-triangle
branch
from
4861247
to
0053c96
Compare
doodlewind
changed the title
whenHover API
doodlewind
reviewed
Oct 13, 2023
lawvs
force-pushed
the
feat/safe-triangle
branch
from
bcdeac3
to
3b16b16
Compare
lawvs
force-pushed
the
feat/safe-triangle
branch
from
3b16b16
to
a627fb7
Compare
Flrande
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the safe triangle feature that was mentioned in #4689
It is worth noting that this new feature has almost no significance for blocksuite now, so this feature is closed by default. It can be enabled by adding
safeTriangleoptions in thewhenHoverAPI.Screen.Recording.2023-10-08.at.00.19.57.mp4
Additionally, this PR added a virtual safe bridge between the reference element and the floating element. This feature is enabled by default and can be disabled by add
safeBridgeoptions in thewhenHoverAPI.Screen.Recording.2023-10-12.at.02.39.13.mov
References