Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(edgeless): improper handler removement #5054

Merged
merged 2 commits into from
Oct 19, 2023
Merged

fix(edgeless): improper handler removement #5054

merged 2 commits into from
Oct 19, 2023

Conversation

fourdim
Copy link
Contributor

@fourdim fourdim commented Oct 18, 2023

No description provided.

@vercel
Copy link

vercel bot commented Oct 18, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2023 5:55pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Oct 18, 2023 5:55pm

@fourdim fourdim enabled auto-merge (squash) October 18, 2023 16:38
@fourdim fourdim mentioned this pull request Oct 18, 2023
Merged
lawvs
lawvs reviewed Oct 18, 2023
View reviewed changes
Copy link
Member

@lawvs lawvs left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The void in TypeScript means we don't care about the return value, maybe we can use the following pattern:

  // declare return void manually, so we no need to modify other code
  private _onCut: (e: ClipboardEvent) => void = async (e: ClipboardEvent) => {
  }

@fourdim fourdim merged commit 5dad7f7 into toeverything:master Oct 19, 2023
18 checks passed
@fourdim fourdim deleted the handler branch November 5, 2023 20:18
@fourdim fourdim mentioned this pull request Dec 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lawvs lawvs lawvs left review comments

@doodlewind doodlewind doodlewind approved these changes

Assignees

@fourdim fourdim

Labels
None yet
Projects
AFFiNE Project
Archived in project
BlockSuite Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fourdim @doodlewind @lawvs