Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(edgeless): edgeless toolbar submenu tooltip position #5123

Conversation

donteatfriedrice
Copy link
Member

Edgeless toolbar submenu tooltips are no longer affected by overflow since affine-tooltip is a portal currently with pr #4950.
So we can set all the submenu tooltip position as default ('top').

@vercel
Copy link

vercel bot commented Oct 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2023 10:05am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Oct 25, 2023 10:05am

Copy link
Member

@doodlewind doodlewind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@doodlewind doodlewind merged commit 2af14e7 into toeverything:master Oct 25, 2023
20 checks passed
@donteatfriedrice donteatfriedrice deleted the fix/edgeless-toolbar-tooltip-position branch October 26, 2023 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants