Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(edgeless): new way to add connectors #5161

Merged
merged 16 commits into from
Nov 3, 2023
Merged

feat(edgeless): new way to add connectors #5161

merged 16 commits into from
Nov 3, 2023

Conversation

donteatfriedrice
Copy link
Member

@donteatfriedrice donteatfriedrice commented Oct 31, 2023 •
edited

Part of #4978 : a new way of adding a connector

  • Drag on shape auto-complete button can add connector and select connector target type, including 5 shape types, canvas text, note, frame
  • Add placeholder for the different target types
  • Make frame connectable

@vercel
Copy link

vercel bot commented Oct 31, 2023

@donteatfriedrice is attempting to deploy a commit to the toeverything Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Oct 31, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 3, 2023 0:42am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Nov 3, 2023 0:42am

@donteatfriedrice donteatfriedrice marked this pull request as draft October 31, 2023 11:47
@donteatfriedrice donteatfriedrice marked this pull request as ready for review November 1, 2023 18:39
doodlewind
doodlewind approved these changes Nov 3, 2023
View reviewed changes
Copy link
Member

@doodlewind doodlewind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This generally looks good, thanks for the feat!

@doodlewind doodlewind added the notable Major improvement worth emphasizing label Nov 3, 2023
@doodlewind doodlewind merged commit 1309234 into toeverything:master Nov 3, 2023
17 of 18 checks passed
@donteatfriedrice donteatfriedrice deleted the feat/new-way-to-add-connectors branch November 9, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doodlewind doodlewind doodlewind approved these changes

@regischen regischen regischen approved these changes

Assignees

@donteatfriedrice donteatfriedrice

Labels
notable Major improvement worth emphasizing
Projects
AFFiNE Project
Archived in project
BlockSuite Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@donteatfriedrice @doodlewind @regischen