fix: sync PageMeta.title with PageBlockModel.title while importing markdown files
#5297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g markdown files
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
affine-bot
reviewed
Nov 12, 2023
There was a problem hiding this comment.
Hello! Thank you for your contribution.
In order for us to review and merge your suggested changes, please sign our CLA at https://github.com/toeverything/blocksuite/edit/master/.github/CLA.md
|
Hi, could you please open a new pull request to add your name directly to the https://github.com/toeverything/blocksuite/edit/master/.github/CLA.md so that we can review this PR? |
Sure. #5298 |
fourdim
reviewed
Nov 12, 2023
lawvs
requested changes
Nov 12, 2023
|
This PR will be approved and merged once the CLA PR is approved. |
lawvs
approved these changes
Nov 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5296. Thank @lawvs for guidance.