-
-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(edgeless): allow canvas content interleaving with DOM based on LayerManager
#5347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
doodlewind
added
notable
Major improvement worth emphasizing
and removed
dont merge
Experimental pull requests
labels
Nov 18, 2023
Finally |
doodlewind
changed the title
feat(edgeless): allow surface elements to adjust index along with block
feat(edgeless): allow canvas content interleaving with DOM based on Nov 28, 2023
LayerManager
doodlewind
approved these changes
Nov 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Design
In order to allow canvas content to interleave with the DOM content, the canvas content should be able to be rendered on an isolated canvas. The isolated canvas can have its own
z-index
property, allowing it to be rendered between stacked DOM elements.We have introduced the
LayerManager
component that places elements into different layers based on their index property and rendering type. If multiple elements with consecutive indices have the same rendering type, they will be placed within the same layer.In the following example, the elements have been grouped into three layers:
After building layers, we are able to decide which layer could and should be rendered on an isolated canvas. In this example, the first layer should be rendered on an isolated canvas with the lowest index, and the third layer can be rendered on the main canvas which is always rendered on the very top.
Todo: