Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(edgeless): for group element, apply local record update recursively #5393

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

AyushAgrawal-A2
Copy link
Contributor

@AyushAgrawal-A2 AyushAgrawal-A2 commented Nov 21, 2023

closes #5373

before:

scrnli_11_21_2023_5-23-15.PM.mp4

after:

scrnli_11_21_2023_5-24-28.PM.mp4

Changes:

  • Group element update needs to be applied to all the child elements, recursively.

Copy link

vercel bot commented Nov 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2023 11:30am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Nov 21, 2023 11:30am

@AyushAgrawal-A2 AyushAgrawal-A2 marked this pull request as draft November 21, 2023 11:30
@AyushAgrawal-A2 AyushAgrawal-A2 changed the title fix(edgeless): group apply local record to yjs fix(edgeless): for group element, apply local record update recursively Nov 21, 2023
@AyushAgrawal-A2 AyushAgrawal-A2 marked this pull request as ready for review November 21, 2023 11:56
@doodlewind doodlewind merged commit 11e9380 into toeverything:master Nov 21, 2023
23 checks passed
@AyushAgrawal-A2 AyushAgrawal-A2 deleted the ayush/5373 branch November 21, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Archived in project
Development

Successfully merging this pull request may close these issues.

Undo not correct after group resize
2 participants