-
-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: size report workflow #5412
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello! Thank you for your contribution.
In order for us to review and merge your suggested changes, please sign our CLA at https://github.com/toeverything/blocksuite/edit/master/.github/CLA.md
@doouding / @doodlewind , Could you please guide with the PR title lint and regarding the test. It passed in my forked repo, Is that possible for you to re run the failed jobs? |
@doodlewind , The PR title lint still failed |
Except the PR title lint, everything passed |
@doodlewind , Can you link issue #5408 |
@Rachit1313 I think you can simply add "close #xxx" in your PR description. |
Done, Thanks. Every check is passing except PR title lint, not sure why? |
failed with ✖ scope must be one of [page, edgeless, database, virgo, store, std, playground] |
@doodlewind Based on your lint file, ["page", "edgeless", "database", "virgo", "store", "std", "playground"] These are the only scopes supported and I don't see ci or cu here. |
@doodlewind , good to go. Let me know if any changes are required before merging? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Description:
This pull request addresses a TypeScript type error in the
vite.config.size.ts
file. The issue was related to the type inference of thebase
configuration. TypeScript was expecting a function call, butbase
was a function itself.To resolve this, I explicitly annotated the type of the
base
configuration invite.config.size.ts
file. Additionally, I ensured that thebase
function is called with the required parameter{ mode: process.env.NODE_ENV }
in thevite.config.size.ts
file.These changes fix the TypeScript type errors and allow for a smooth build process.
Changes Made:
vite.config.size.ts
to call thebase
function with the necessary parameter.Testing:
This resolves issue #5408
close #5408