Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: size report workflow #5412

Merged
merged 6 commits into from
Nov 23, 2023
Merged

fix: size report workflow #5412

merged 6 commits into from
Nov 23, 2023

Conversation

Rachit1313
Copy link
Contributor

@Rachit1313 Rachit1313 commented Nov 23, 2023

Description:

This pull request addresses a TypeScript type error in the vite.config.size.ts file. The issue was related to the type inference of the base configuration. TypeScript was expecting a function call, but base was a function itself.

To resolve this, I explicitly annotated the type of the base configuration in vite.config.size.ts file. Additionally, I ensured that the base function is called with the required parameter { mode: process.env.NODE_ENV } in the vite.config.size.ts file.

These changes fix the TypeScript type errors and allow for a smooth build process.

Changes Made:

  • Modified vite.config.size.ts to call the base function with the necessary parameter.

Testing:

  • Tested the changes locally to ensure there are no TypeScript type errors.
  • Verified that the build process completes successfully after the modifications.

This resolves issue #5408
close #5408

Copy link

vercel bot commented Nov 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 23, 2023 7:21am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Nov 23, 2023 7:21am

Copy link

@affine-bot affine-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Thank you for your contribution.

In order for us to review and merge your suggested changes, please sign our CLA at https://github.com/toeverything/blocksuite/edit/master/.github/CLA.md

@Rachit1313
Copy link
Contributor Author

image This commit passed all the tests on the forked repo.

@Rachit1313
Copy link
Contributor Author

@doouding / @doodlewind , Could you please guide with the PR title lint and regarding the test. It passed in my forked repo, Is that possible for you to re run the failed jobs?

@doodlewind doodlewind changed the title fixed Size report workflow #5408 fix(cu): size report workflow Nov 23, 2023
@Rachit1313
Copy link
Contributor Author

@doodlewind , The PR title lint still failed

@Rachit1313
Copy link
Contributor Author

@doodlewind , The PR title lint still failed

Except the PR title lint, everything passed

@Rachit1313
Copy link
Contributor Author

@doodlewind , Can you link issue #5408

@doodlewind
Copy link
Member

@Rachit1313 I think you can simply add "close #xxx" in your PR description.

@Rachit1313
Copy link
Contributor Author

@Rachit1313 I think you can simply add "close #xxx" in your PR description.

Done, Thanks. Every check is passing except PR title lint, not sure why?

@doodlewind doodlewind changed the title fix(cu): size report workflow fix(ci): size report workflow Nov 23, 2023
@Rachit1313
Copy link
Contributor Author

failed with ✖ scope must be one of [page, edgeless, database, virgo, store, std, playground]

@Rachit1313
Copy link
Contributor Author

failed with ✖ scope must be one of [page, edgeless, database, virgo, store, std, playground]

@doodlewind Based on your lint file, ["page", "edgeless", "database", "virgo", "store", "std", "playground"] These are the only scopes supported and I don't see ci or cu here.

@doodlewind doodlewind changed the title fix(ci): size report workflow fix: size report workflow Nov 23, 2023
@Rachit1313
Copy link
Contributor Author

@doodlewind , good to go. Let me know if any changes are required before merging?

Copy link
Member

@doodlewind doodlewind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@doodlewind doodlewind merged commit 02664d5 into toeverything:master Nov 23, 2023
17 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Archived in project
Development

Successfully merging this pull request may close these issues.

The size report CI action failed
3 participants