Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(edgeless): new TOC #5539

Merged
merged 13 commits into from
Dec 1, 2023
Merged

Conversation

donteatfriedrice
Copy link
Member

@donteatfriedrice donteatfriedrice commented Nov 30, 2023

Copy link

vercel bot commented Nov 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 1, 2023 7:35am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Dec 1, 2023 7:35am

@zanwei
Copy link
Member

zanwei commented Nov 30, 2023

Had a discussion with @donteatfriedrice internally. There are still some details that need to be fixed.

@doodlewind doodlewind added the notable Major improvement worth emphasizing label Nov 30, 2023
@doodlewind doodlewind added the ui-style Related to UI styling label Nov 30, 2023
@zanwei
Copy link
Member

zanwei commented Dec 1, 2023

Approved. Looks good to me

Copy link
Member

@doodlewind doodlewind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feat!

@doodlewind doodlewind enabled auto-merge (squash) December 1, 2023 07:34
@doodlewind doodlewind merged commit a1559b1 into toeverything:master Dec 1, 2023
19 checks passed
@zanwei
Copy link
Member

zanwei commented Dec 8, 2023

Had a discussion internally with @donteatfriedrice. There'a modification needs to be update

  1. table of content When the text is not cut, it is necessary to click the corresponding block and jump to the target position. The corresponding block text is highlighted and returns to the default state after 1 second.
  2. Placeholder block display type name
image

@zanwei
Copy link
Member

zanwei commented Dec 11, 2023

We've further discussion about TOC and we like to have an update.

  1. Check whether the user has written content in the block. If there is no content, it will not be displayed in the TOC.
  2. TOC when the text is not cut, it is necessary to click the corresponding block and jump to the target position. The corresponding block text is highlighted and returns to the default state after 1 second.
  3. Placeholder block display type name

UI update

  1. Please update the font size from 15px(base) to 14px(sm)
  2. Please update the top&bot padding from 8px to 6px
image
  1. Please update the indentation of different types of blocks
  2. Please update the index number font size from 12px to 14px
image
  1. Change the title from a full-write to the first letter uppercase
image

cc @donteatfriedrice

@donteatfriedrice
Copy link
Member Author

Doc mode:

  1. Display text outline.
  2. Click to navigate to specific block.
  3. Update outline in realtime.
Screen.Recording.2023-12-15.at.17.40.18.mov

@donteatfriedrice
Copy link
Member Author

donteatfriedrice commented Dec 15, 2023

Edgeless mode:

  1. Display outline by note level (including doc-mode visible and hidden notes).
  2. Click to select note on edgeless mode.
  3. Shift-click to multi-select.
  4. Double Click to navigate to specific note.
  5. Update panel in real-time.
  6. Dnd to reorder notes sequence. This will change the order notes show in doc mode.
Screen.Recording.2023-12-15.at.17.41.00.mov
Screen.Recording.2023-12-15.at.17.51.08.mov

@donteatfriedrice
Copy link
Member Author

Settings:

  1. Support hiding block type icons.
Screen.Recording.2023-12-15.at.17.41.53.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notable Major improvement worth emphasizing ui-style Related to UI styling
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants