refactor: move to single contenteditable #5850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Ignored Deployments
|
Saul-Mirone
reviewed
Jan 18, 2024
| mode: 'flat', | ||
| }); | ||
|
|
||
| const start = blocks.at(0); |
There was a problem hiding this comment.
Seems repeat with line 196
There was a problem hiding this comment.
Do you mean them?
const start = blocks.at(0);
const end = blocks.at(-1);
if (!start || !end) return;
const startText = start.model.text;
const endText = end.model.text;
if (!startText || !endText) return;
Saul-Mirone
reviewed
Jan 18, 2024
| index: endInlineRange.index, | ||
| length: endInlineRange.length, | ||
| }, | ||
| isReverse: reverse, |
There was a problem hiding this comment.
Do we still need this property? I remember that this property was used to navigate with keyboard. Maybe we can try to remove it.
There was a problem hiding this comment.
Maybe we can use it to improve UX in remote-selection? 🤔
There was a problem hiding this comment.
You mean the position of the name flag?
There was a problem hiding this comment.
And I want to rename isReverse to reverse 🤪
This reverts commit 37d6bdf.
Saul-Mirone
approved these changes
Jan 19, 2024
This was referenced Jan 22, 2024
Closed
This was referenced Jan 26, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1218