-
-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: support multiple-editors #5878
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
0ceedd1
to
752bc58
Compare
752bc58
to
2980911
Compare
2980911
to
b5c24c9
Compare
b5c24c9
to
d6473a6
Compare
fd3e388
to
d41dc44
Compare
d41dc44
to
36ccfd2
Compare
7cdc79b
to
3437dd0
Compare
3437dd0
to
b7c4ced
Compare
b7c4ced
to
b2f4e51
Compare
b2f4e51
to
319edd0
Compare
319edd0
to
33980b8
Compare
@doodlewind is the same issue occurring for doc-edgeless , edgeless-edgeless as well ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AyushAgrawal-A2 I double checked and all examples work now, that's awesome!
Generally LGTM but for some updates in block-std
, I'd require @Saul-Mirone for better review.
These entries are also great, I also plan to use similar entry in the newly added https://blocksuite.io/doc-editor.html and https://blocksuite.io/edgeless-editor.html doc pages.
15a2e8b
to
341fd7b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should land this, happy new year!
continuation of #5765
closes #5625
closes #5153
Changes:
Completed pending cleanup global querySelectors and events
UIEventDispatcher:
I tried moving events from document to editorHost, but there were few events which will originate from the document only. In multiple editor scenario each editor needs to be aware whether it is active or not, and respond to events only is it active.
I have added a static field on UIEventDispatcher, which stores which dispatcher and thus which editor is active. It will run event handlers only if it is active.
For ease of testing of all three scenarios, added examples of independent multiple editors - doc-doc, doc-edgeless & edgeless-edgeless at