Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(page): enter in title move cursor #5962

Merged
merged 3 commits into from
Jan 12, 2024
Merged

fix(page): enter in title move cursor #5962

merged 3 commits into from
Jan 12, 2024

Conversation

regischen
Copy link
Member

close #5960

Copy link

vercel bot commented Jan 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 11, 2024 11:55am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Jan 11, 2024 11:55am

@AyushAgrawal-A2
Copy link
Contributor

AyushAgrawal-A2 commented Jan 11, 2024

@regischen
can we add this.host.event.activate(); inside the asyncFocusRichText function... it will solve other such scenarios as well, as editor should always be active when focus text is called

tests/hotkey.spec.ts Outdated Show resolved Hide resolved
@doodlewind doodlewind changed the title fix: enter in title move cursor fix(page): enter in title move cursor Jan 11, 2024
@doodlewind
Copy link
Member

@regischen

can we add this.host.event.activate(); inside the asyncFocusRichText function... it will solve other such scenarios as well, as editor should always be active when focus text is called

@regischen PTAL

@regischen
Copy link
Member Author

@regischen can we add this.host.event.activate(); inside the asyncFocusRichText function... it will solve other such scenarios as well, as editor should always be active when focus text is called

I'm not sure if this is best approach. \cc @Saul-Mirone

@regischen regischen merged commit 66f20bd into master Jan 12, 2024
19 checks passed
@regischen regischen deleted the fix-enter-title branch January 12, 2024 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Enter key not work in title
3 participants