fix(page): show backlink for affine:embed-linked-doc
#5986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AyushAgrawal-A2
requested review from
Saul-Mirone and
doodlewind
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
AyushAgrawal-A2
changed the title
affine:embed-linked-docaffine:embed-linked-doc
doodlewind
reviewed
Jan 14, 2024
| @@ -12,6 +12,7 @@ export const EmbedLinkedDocStyles: EmbedCardStyle[] = [ | |||
|
|
|||
| export type EmbedLinkedDocBlockProps = { | |||
| pageId: string; | |||
| type: 'Subpage' | 'LinkedPage'; | |||
There was a problem hiding this comment.
We should try to remove Subpage in newly created data and code. Is it possible to use only LinkedPage here?
There was a problem hiding this comment.
@doodlewind
done
AyushAgrawal-A2
force-pushed
the
ayush/embed-linked-doc-backlink
branch
from
3c05937
to
477e478
Compare
doodlewind
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding backlink support for
affine:embed-linked-doc