Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support embed-figma block type #5988

Merged
merged 5 commits into from
Jan 16, 2024
Merged

feat: support embed-figma block type #5988

merged 5 commits into from
Jan 16, 2024

Conversation

AyushAgrawal-A2
Copy link
Contributor

@AyushAgrawal-A2 AyushAgrawal-A2 commented Jan 14, 2024 •
edited

Figma

Changes:

  • Implemented Embed-Figma (doc & edgeless)
  • Added to slash-menu & edgeless-toolbar
  • Reload button on toolbar (doc & edgeless)

@vercel Vercel
Copy link

vercel bot commented Jan 14, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2024 8:13am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Jan 16, 2024 8:13am

@AyushAgrawal-A2 AyushAgrawal-A2 marked this pull request as draft January 14, 2024 15:24
Svaney-ssman
Svaney-ssman reviewed Jan 15, 2024
View reviewed changes
Copy link

@Svaney-ssman Svaney-ssman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for updating design late. We need to adjust the dimensions of Figma's embed match to those of Youtube

@AyushAgrawal-A2 AyushAgrawal-A2 marked this pull request as ready for review January 15, 2024 06:39
Svaney-ssman
Svaney-ssman reviewed Jan 15, 2024
View reviewed changes
Copy link

@Svaney-ssman Svaney-ssman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. remove this tooltip
image
  1. caption button is missing in edgeless mode

@doodlewind doodlewind added the notable Major improvement worth emphasizing label Jan 15, 2024
@doodlewind doodlewind changed the title feat: embed-figma feat: support embed-figma block type Jan 16, 2024
doodlewind
doodlewind reviewed Jan 16, 2024
View reviewed changes
Copy link
Member

@doodlewind doodlewind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems that the button spacing may need to be fine-tuned.

image

@AyushAgrawal-A2
Copy link
Contributor Author

Seems that the button spacing may need to be fine-tuned.

image

@doodlewind done

image

doodlewind
doodlewind approved these changes Jan 16, 2024
View reviewed changes
Copy link
Member

@doodlewind doodlewind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great progress! The timing is great, since we are launching next AFFiNE beta and this is a good point to be included.

@doodlewind doodlewind merged commit 71c8545 into toeverything:master Jan 16, 2024
19 checks passed
@AyushAgrawal-A2 AyushAgrawal-A2 deleted the ayush/embed-figma branch January 16, 2024 10:22
@joooye34 joooye34 mentioned this pull request Feb 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doodlewind doodlewind doodlewind approved these changes

@Saul-Mirone Saul-Mirone Awaiting requested review from Saul-Mirone

@houjoe0829 houjoe0829 Awaiting requested review from houjoe0829

@hwangdev97 hwangdev97 Awaiting requested review from hwangdev97

@Flrande Flrande Awaiting requested review from Flrande

@Svaney-ssman Svaney-ssman Awaiting requested review from Svaney-ssman

Assignees

@AyushAgrawal-A2 AyushAgrawal-A2

Labels
notable Major improvement worth emphasizing
Projects
BlockSuite Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AyushAgrawal-A2 @doodlewind @Svaney-ssman