Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change note visibility #5994

Conversation

donteatfriedrice
Copy link
Member

@donteatfriedrice donteatfriedrice commented Jan 15, 2024

Support to change note visibility:

  • note:props:hidden -> note:props:displayMode . Note now has three different display mode:
    • DocOnly: only display the note (note content) in doc mode and can not be selected in edgeless mode.
    • EdgelessOnly: only display the note (note content) in edgeless mode.
    • DocAndEdgeless: display on both doc and edgeless modes.
  • User can change note display mode with note toolbar or outline panel.
  • Update note auto complete buttons, only keep the buttons on the left and right sides,and the left button would be hidden when zoom greater than 150%.
  • Remove auto connect line.
  • Update index label. Page visible and edgeless only note will have different index label and tooltip.
  • Update outline panel empty placeholder.
  • Note added on doc mode will display on both doc and edgeless by default. While added on edgeless mode will display on edgeless mode by default. ( notes in templates will display on edgeless only by default ).
  • Add a notice board in outline panel to notice user some contents hidden on edgeless page if there are doc only notes.

Copy link

vercel bot commented Jan 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2024 5:47pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Jan 17, 2024 5:47pm

@donteatfriedrice donteatfriedrice marked this pull request as draft January 15, 2024 09:01
@donteatfriedrice donteatfriedrice changed the title Feat/support change note visibility feat: change note visibility Jan 15, 2024
@donteatfriedrice donteatfriedrice marked this pull request as ready for review January 17, 2024 17:58
@doodlewind doodlewind added the notable Major improvement worth emphasizing label Jan 18, 2024
Copy link
Member

@doodlewind doodlewind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the feat!

@doodlewind doodlewind merged commit a613170 into toeverything:master Jan 18, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notable Major improvement worth emphasizing
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants